Talk:Complete Roguelike Tutorial, using python+libtcod, part 5

This is a really splendid tutorial!

Two minor suggestions for improvement:

• In make_map: Move the call to place_objects(new_room) to just before appending the new_room. Else the player may be placed on top of an object (since the player-placement does not check for blocking).
• In place_objects: When computing the random spot for a monster, using values room.x1 and room.x2 without without modification allows monsters to be placed in the walls of the room. (Those placements are pruned afterwards when checking against is_blocked, but it results in fewer monsters than expected being placed.) --Dontroel 21:31, 22 March 2012 (CET)
  • Hehe. Finally had the time to make it to part 8 of the tutorial. I see that you make a nice pedagogical point of fixing precisely the slight error in placement of monsters. :) I'll just leave this comment here, if other readers are puzzled about this and should check this discussion page. --Dontroel 12:11, 1 April 2012 (CEST)

Hi, I'm glad you like it :) About the second point, yes it's fixed later! It's easier for people who are already following the tutorial to take note of changes this way, than if I just go back and change earlier parts of the tutorial. It's also a bit more organic, since no code is set in stone... Which brings me to your first point! Nice catch, I'll put it on the list of stuff to fix. Remember that changes must be replicated in all parts so I prefer to fix everything in one go (maybe after I finish the next part). Cheers! Jotaf 05:41, 17 April 2012 (CEST)