Difference between revisions of "Talk:Complete Roguelike Tutorial, using python+libtcod, part 5"
Jump to navigation
Jump to search
(Created page with "This is a really splendid tutorial! Two minor suggestions for improvement: * In make_map: Move the call to place_objects(new_room) to just before appending the new_room. Else th...") |
|||
| Line 3: | Line 3: | ||
Two minor suggestions for improvement: | Two minor suggestions for improvement: | ||
* In make_map: Move the call to place_objects(new_room) to just before appending the new_room. Else the player may be placed on top of an object (since the player-placement does not check for blocking). | * In make_map: Move the call to place_objects(new_room) to just before appending the new_room. Else the player may be placed on top of an object (since the player-placement does not check for blocking). | ||
* In place_objects: When computing the random spot for a monster, using values room.x1 and room.x2 without without modification allows monsters to be placed in the walls of the room. (Those placements are pruned afterwards when checking against is_blocked, but it results in fewer monsters than expected | * In place_objects: When computing the random spot for a monster, using values room.x1 and room.x2 without without modification allows monsters to be placed in the walls of the room. (Those placements are pruned afterwards when checking against is_blocked, but it results in fewer monsters than expected being placed.) --[[User:Dontroel|Dontroel]] 21:31, 22 March 2012 (CET) | ||
** Hehe. Finally had the time to make it to part 8 of the tutorial. I see that you make a nice pedagogical point of fixing precisely the slight error in placement of monsters. :) I'll just leave this comment here, if other readers are puzzled about this and should check this discussion page. --[[User:Dontroel|Dontroel]] 12:11, 1 April 2012 (CEST) | |||
--[[User:Dontroel|Dontroel]] 21:31, 22 March 2012 (CET) | |||
Revision as of 10:11, 1 April 2012
This is a really splendid tutorial!
Two minor suggestions for improvement:
- In make_map: Move the call to place_objects(new_room) to just before appending the new_room. Else the player may be placed on top of an object (since the player-placement does not check for blocking).
- In place_objects: When computing the random spot for a monster, using values room.x1 and room.x2 without without modification allows monsters to be placed in the walls of the room. (Those placements are pruned afterwards when checking against is_blocked, but it results in fewer monsters than expected being placed.) --Dontroel 21:31, 22 March 2012 (CET)
- Hehe. Finally had the time to make it to part 8 of the tutorial. I see that you make a nice pedagogical point of fixing precisely the slight error in placement of monsters. :) I'll just leave this comment here, if other readers are puzzled about this and should check this discussion page. --Dontroel 12:11, 1 April 2012 (CEST)